[FFmpeg-devel] [PATCH] rtsp - alternate protocol

Luca Abeni lucabe72
Sun Dec 30 12:50:10 CET 2007


Hi Michael,

Michael Niedermayer wrote:
[...]
>> I did some tests with various url_split() versions and with current svn + 
>> your patch, and it seems to me that your patch fixes almost all the 
>> testcases. I only found a case about which I am not sure: the URL 
>> rtp://localhost?localport=5000 gives ?localport=5000 as path. I suspect 
>> this is wrong (?localport=5000 should be the path for 
>> rtp://localhost/?localport=5000, right?).
> 
> IIRC rich said '?' counts as host / path seperator if theres no '/'

Ah, ok... I was not aware of this convention


> either way ive commited my patch. We can always commit your interdiff
> if we find a case where it causes problems.

Ok. I did some more tests, and I do not see any problems. So, I guess 
the code is ok as it is now.

BTW, I seem to remember some discussions some time ago about people 
having problems with youtube urls... I do not know if such problems were 
resolved or not, but maybe your patch just fixed them :)


			Thanks,
				Luca




More information about the ffmpeg-devel mailing list