[Ffmpeg-devel] Re: libavformat cruft

[Michel Bardiaux]

Baptiste Coudurier wrote:
> Hi
> 
> Diego Biurrun wrote:
>> On Thu, Feb 01, 2007 at 04:34:26PM +0100, Michel Bardiaux wrote:
>>> Michael Niedermayer wrote:
>>>> On Wed, Jan 24, 2007 at 07:26:44PM +0100, Diego Biurrun wrote:
>>>>> On Wed, Jan 24, 2007 at 07:13:27PM +0100, Diego Biurrun wrote:
>>>>>> On Tue, Jan 23, 2007 at 03:25:33PM +0100, Michael Niedermayer wrote:
>>>>>>> On Tue, Jan 23, 2007 at 10:22:46AM +0100, Diego Biurrun wrote:
>>>>>>>> On Mon, Jan 22, 2007 at 05:12:22PM +0100, Michel Bardiaux wrote:
>>>>>>>>> AFAICS img.c should be removed. But I couldnt find a way to make a 
>>>>>>>>> patch file for such operation. Is it at all possible?
>>>>>>>> No need to send a patch for this.
>>>>>>>>
>>>>>>>> There are at least two more files in libavformat/, png.c and pnm.c, are
>>>>>>>> they old cruft that can be removed or what do we make of them?
>>>>>>> do libavcodec/png/pnm work if so remove the libavformat ones
>>>>>> Mans removed these two.  What about img.c now?  Can it be removed?
>>>>> Other files which appear unused are cutils.c, jpeg.c, sgi.c, yuv.c.
>>>> all the img.c and related files can be removed if they work with img2
>>> cutils still appears in the Makefile, but img.c jpeg.c sgi.c yuv.c dont. 
>>> Could someone svn delete them?
>> Can somebody confirm that this stuff works with img2 now?
> 
> Honestly it should, code is disabled since I removed AVImageFormat,
> sgi was broken anyway.
> 
Maybe Diego means we should keep the code around as a source of 
inspiration for re-implementing the sgi image codec. But anyone 
interested can always retrieve it with svn co -r

img2 jpeg streams are known to work. yuv... well, I have problems, but 
since I'm not sure the problem is not with my options, I will refrain 
until Im sure.


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/