[Ffmpeg-devel] Re: [PATCH] file length handling

Michael Niedermayer michaelni
Mon Jan 1 23:01:16 CET 2007


On Sun, Dec 31, 2006 at 03:25:51PM -0500, Ronald S. Bultje wrote:
> Hi Michael,
> On Fri, 2006-12-29, Michael Niedermayer wrote:
> > On Wed, Dec 27, 2006 at 08:11:39PM -0500, Ronald S. Bultje wrote:
> > > I don't mind if file_size is not available for a while (until whenever
> > > is the next time that ABI is broken) on such streams, but it should be,
> > > eventually. Adding file_size really is the right thing to do, imo.
> > 
> > if the patch which adds file_size + a function pointer for ByteIOContext
> > is small then ive no objections if its large i do have objections ...
> OK, I've attached a patch below which does just that.

i think ive found a much simpler solution (see svn(log)) ...

> As for the small second patch, I noticed misbehaviour in url_fseek()
> when seeking fails. The return value of the seek function in my http.
> seek implementation and from lseek() in file.c (only protocol
> implementing seek so far) is -1 on error, not -EPIPE (the return value
> in url_seek() if no seek function pointer is set), hence the bugfix.
> Should be a no-brainer.

looks ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070101/d9bce5c4/attachment.pgp>

More information about the ffmpeg-devel mailing list