[Ffmpeg-devel] Re: [PATCH] file length handling

Ronald S. Bultje rbultje
Tue Jan 2 02:11:14 CET 2007

On Mon, 2007-01-01, Michael Niedermayer wrote:
> On Sun, Dec 31, 2006 at 03:25:51PM -0500, Ronald S. Bultje wrote:
> > OK, I've attached a patch below which does just that.
> i think ive found a much simpler solution (see svn(log)) ...

Ah, that's much better indeed, thanks. You'll probably still want to
protect the size=seek(SEEK_END,-1)+1 results with an if (.. < 0), else
the return value may still end up being zero (if the seek returns -1,
which is e.g. what file.c will return on error), which is a valid (but
incorrect) filesize.

Patch for that attached.

(And is anyone actually applying my patches? There's also still the
vorbis metadata patch that never got committed, afaik. Not that I mind
waiting, just want to make sure they don't get forgotten.)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: d
Type: text/x-patch
Size: 1010 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070101/e898b9df/attachment.bin>

More information about the ffmpeg-devel mailing list