[Ffmpeg-devel] Re: [PATCH] file length handling

Michael Niedermayer michaelni
Tue Jan 2 02:27:46 CET 2007


On Mon, Jan 01, 2007 at 08:11:14PM -0500, Ronald S. Bultje wrote:
> On Mon, 2007-01-01, Michael Niedermayer wrote:
> > On Sun, Dec 31, 2006 at 03:25:51PM -0500, Ronald S. Bultje wrote:
> > > OK, I've attached a patch below which does just that.
> > 
> > i think ive found a much simpler solution (see svn(log)) ...
> Ah, that's much better indeed, thanks. You'll probably still want to
> protect the size=seek(SEEK_END,-1)+1 results with an if (.. < 0), else
> the return value may still end up being zero (if the seek returns -1,
> which is e.g. what file.c will return on error), which is a valid (but
> incorrect) filesize.
> Patch for that attached.

looks ok

> (And is anyone actually applying my patches? There's also still the
> vorbis metadata patch that never got committed, afaik. Not that I mind
> waiting, just want to make sure they don't get forgotten.)

just periodically (once a month or so) send a remainder about patches
which arent rejected and havent been applied this should be either
as a reply to each patch (with correct headers so it is shown correctly
in threaded MUAs) or as a list of subjects (+dates) of the respective
mails in which the patches are

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070102/ffc8742a/attachment.pgp>

More information about the ffmpeg-devel mailing list