[Ffmpeg-devel] swscale failed tests
Sat Jan 6 16:01:47 CET 2007
On Wed, Jan 03, 2007 at 02:15:06PM +0100, Luca Abeni wrote:
> On Wed, 2007-01-03 at 09:40 +0100, Luca Abeni wrote:
> > Maybe the right thing to do for now would be to check for
> > ENABLE_SWSCALER in the tests makefile, and return a meaningful error
> > message if it is set. I'll send a patch later.
> Ok, here is the patch... I do not know if it is appropriate or not; it's
> just a proposal for avoiding to worry people that configure with
> --enable-swscaler and see "make test" faling.
The patch is basically good, but ..
> --- tests/Makefile (revision 7406)
> +++ tests/Makefile (working copy)
> @@ -16,7 +16,14 @@
> +ifeq ($(CONFIG_SWSCALER),yes)
> +all fulltest test:
> + @echo
> + @echo "Cannot perform tests if libswscaler is enabled"
Nit: Missing period at the end.
Also, there is no such thing as libswscaleR. The directory is called
libswscale, the program software scaler, the configure option swscaler.
We should settle on a name someday.
> + @echo
> all fulltest test: codectest libavtest test-server
Do both codectest and libavtest fail? What if I call codectest or
libavtest directly? I think your patch will not help then...
More information about the ffmpeg-devel