[Ffmpeg-devel] swscale failed tests

Luca Abeni lucabe72
Sun Jan 7 12:50:20 CET 2007


Hi Diego,

On Sat, 2007-01-06 at 16:01 +0100, Diego Biurrun wrote:
[...]
> > --- tests/Makefile	(revision 7406)
> > +++ tests/Makefile	(working copy)
> > @@ -16,7 +16,14 @@
> >  
> > +ifeq ($(CONFIG_SWSCALER),yes)
> > +all fulltest test:
> > +	@echo
> > +	@echo "Cannot perform tests if libswscaler is enabled"
> 
> Nit: Missing period at the end.
> 
> Also, there is no such thing as libswscaleR.  The directory is called
> libswscale, the program software scaler, the configure option swscaler.
> We should settle on a name someday.
Ok; maybe the right thing to write here should be "... if the software
scaler is enabled", since "libswscale is enabled" does not make too much
sense :).

> > +	@echo
> > +else
> >  all fulltest test: codectest libavtest test-server
> > +endif
> 
> Do both codectest and libavtest fail?
Yes, they both fail.

> What if I call codectest or libavtest directly?
> I think your patch will not help then...
You are right; I tried to make the patch as simple as possible by only
considering the most common case (make test).
I'll rewrite the patch protecting all the "codectest", "libavtest", and
"test-server" targets with "ifeq ($(CONFIG_SWSCALER),yes)".


			Thanks,
				Luca





More information about the ffmpeg-devel mailing list