[Ffmpeg-devel] [PATCH] Musepack out of bounds accesses

Reimar Döffinger Reimar.Doeffinger
Sun Jan 14 17:15:23 CET 2007

On Sun, Jan 14, 2007 at 07:55:20AM +0200, Kostya wrote:
> On Sat, Jan 13, 2007 at 04:43:28PM +0100, Reimar D?ffinger wrote:
> > attached patch fixes two such.
> > First is in the demuxer during playback-index-building, there is no check that the
> > index array is large enough. It would be possible to realloc it, but I'm
> > not sure if that's such a good idea, thinking e.g. of doing streaming
> > (esp. since I think it does not respect noidx?).
> I don't think it's right solution - maybe that frame should not be passed at all.
> Try to change condition at line 121 and check what happens.

Well, that condition was obviously wrong, I allowed myself to change it
without sending a patch first.
Though I do not like treating the frame count in some header as the ultimate
truth, esp. as it makes it impossible to play files that are in the process
of being created...

> > The other one is because the decoder does not provide the padding the
> > bitstream reader needs.
> This patch is fine to me, apply anytime.


Reimar D?ffinger

More information about the ffmpeg-devel mailing list