[Ffmpeg-devel] [PATCH] install libavformat/riff.h

Michael Niedermayer michaelni
Wed Jan 24 01:11:29 CET 2007


On Wed, Jan 24, 2007 at 12:54:45AM +0100, Nico Sabbi wrote:
> Michael Niedermayer wrote:
> >>
> >>and to riff.h (prepended by ff_):
> >
> >
> >av_ prefix ...
> >
> >anyway ive thought about this a little and ill fix it myself
> >ill add several codec_tag=int<->codec_id=int lists to the AVIn/OutputFormat
> >and export nice functions which can map between them AVCodecTag 
> >(codec_tag, codec_id currently like CodecTag without invalid_asf) will be
> >an opaque struct so user apps wont become dependant on its details
> >
> >to get the best codec tag for asf you could then do
> >av_codec_get_tag(asf_muxer.codec_tag, codec_id);
> >
> >comments welcome but be quick as ill probably have this finished and
> >in svn in a few hours ...
> >
> >[...]
> >
> what about moving the definition of AVCodecTag to avformat.h?
> there's nothing riff-specific in it.

no but its contents might change and that would then require a major
version bump if its officially exported
possible changes would be 64bit tag, maybe a uint8_t *data/len for silly
binary codec tags or arbitrary length strings, some flags like

so no i dont agree to it being moved to avformat.h currently, maybe at
some point in the future but not now ...

> in mplayer's demux_lavf codec_wav_tags and codec_bmp_tags can
> either be declared as extern (without including riff.h) or
> we can add a couple of wrappers, but since they are static const...

well either include riff.h and accpet occasional breakage or use:

typedef struct MPCodecTag {
    int id;
    unsigned int tag;
} MPCodecTag;

with a copy and pasted get_tag() / get_id() from lavf 
its just a few lines of code ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070124/3b3bd03f/attachment.pgp>

More information about the ffmpeg-devel mailing list