[FFmpeg-devel] [PATCH] Mention unneeded casts and parenthesis in Coding Rules (doc)

Vitor vitor1001
Wed Jun 27 11:49:46 CEST 2007

M?ns Rullg?rd wrote:
>>> Since these two things show up very frequently when reviewing patches,
>>> I think they are worth a mention in the documentation.
>>> Warning: I'm a non native english speaker!


>>> +Ideally, casts should be used only when necessary. Unneeded parenthesis
>>> +should also be avoided if they don't make the code easier to understand.
>>> +
>> i think plural is parentheses
> It is.  I'd also drop the "ideally".  An unnecessary cast is a bug.
> Actually, a necessary cast is also often a bug.

Changed both.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: doc2.diff
Type: text/x-patch
Size: 476 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070627/c5e6be68/attachment.bin>

More information about the ffmpeg-devel mailing list