[FFmpeg-devel] [PATCH] Mention unneeded casts and parenthesis in Coding Rules (doc)

Michael Niedermayer michaelni
Wed Jun 27 12:09:42 CEST 2007


On Wed, Jun 27, 2007 at 11:49:46AM +0200, Vitor wrote:
> M?ns Rullg?rd wrote:
> >>>Since these two things show up very frequently when reviewing patches,
> >>>I think they are worth a mention in the documentation.
> >>>
> >>>Warning: I'm a non native english speaker!
> [...]
> >>>+Ideally, casts should be used only when necessary. Unneeded parenthesis
> >>>+should also be avoided if they don't make the code easier to understand.
> >>>+
> >>>  
> >>i think plural is parentheses
> >
> >It is.  I'd also drop the "ideally".  An unnecessary cast is a bug.
> >Actually, a necessary cast is also often a bug.
> >
> Changed both.

looks ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070627/16db636c/attachment.pgp>

More information about the ffmpeg-devel mailing list