[FFmpeg-devel] [patch] error codes for http/tcp

Michael Niedermayer michaelni
Sat Jun 30 19:26:26 CEST 2007


On Sat, Jun 23, 2007 at 11:27:21AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On 6/23/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> >On Sat, Jun 23, 2007 at 10:42:52AM -0400, Ronald S. Bultje wrote:
> >> Index: ffmpeg/configure.ac
> >
> [..]
> 
> this isnt against svn
> 
> 
> Oops, so I don't really know how configure works, is this how I'm supposed
> to do that (I copied localtime_r checks)?
> 
> >+        if (gethostbyname_r(name, &hp_imp, buf, sizeof(buf), &hp,
> >h_errnop);
> >
> >may i suggest that you try to compile your code before submitting it?
> 
> 
> OSX doesn't have this function. :-).

well untested patches are not acceptable
until someone tests it its rejected

[...]
> Index: ffmpeg/libavformat/tcp.c
> ===================================================================
> --- ffmpeg.orig/libavformat/tcp.c	2007-06-05 02:11:13.000000000 -0400
> +++ ffmpeg/libavformat/tcp.c	2007-06-23 10:38:41.000000000 -0400
> @@ -55,7 +55,7 @@
>  
>      dest_addr.sin_family = AF_INET;
>      dest_addr.sin_port = htons(port);
> -    if (resolve_host(&dest_addr.sin_addr, hostname) < 0)
> +    if (resolve_host(&dest_addr.sin_addr, hostname, &ret) < 0)
>          goto fail;

ret is overridden later so its confusing to use it here


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070630/b68f5e06/attachment.pgp>



More information about the ffmpeg-devel mailing list