[FFmpeg-devel] [patch] error codes for http/tcp

[Ronald S. Bultje]

Hi,

On 6/30/07, Michael Niedermayer <michaelni at gmx.at> wrote:
>
> > Index: ffmpeg/libavformat/tcp.c
> > ===================================================================
> > --- ffmpeg.orig/libavformat/tcp.c     2007-06-05 02:11:13.000000000-0400
> > +++ ffmpeg/libavformat/tcp.c  2007-06-23 10:38:41.000000000 -0400
> > @@ -55,7 +55,7 @@
> >
> >      dest_addr.sin_family = AF_INET;
> >      dest_addr.sin_port = htons(port);
> > -    if (resolve_host(&dest_addr.sin_addr, hostname) < 0)
> > +    if (resolve_host(&dest_addr.sin_addr, hostname, &ret) < 0)
> >          goto fail;
>
> ret is overridden later so its confusing to use it here


I said in my original email that my next patch (the tcp errno one) will
actually use this function. Otherwise I have to merge the two patches in
one, which would probably be confusing. Alternatively, I can add an extra
variable already but leave it unused (i.e. not use it after filling in in
resolve_host()) until the next patch. Whichever you prefer.

Ronald