[Ffmpeg-devel] [PATCH] fix EINVAL TO EUNKNOWN

Limin Wang lance.lmwang
Mon Mar 5 09:49:08 CET 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

* Benoit Fouet <benoit.fouet at purplelabs.com> [2007-03-05 09:10:11 +0100]:

> Hi,
> 
> Limin Wang wrote:
> > Hi,
> >
> > Any reason to convert unknown error to invalid error code? Or
> > it's typo only.
> >
> FWIW this error code (EUNKNOWN) doesn't exist on my machine...
> $ grep -R EUNKNOWN /usr/include/
> /usr/include/nspr/plresolv.h:#define PL_RESOLVE_EUNKNOWN     
> 7           /* berserk error */
> /usr/include/wx/stc/stc.h:#define wxSTC_H_ATTRIBUTEUNKNOWN 4
> /usr/include/wine/windows/urlmon.idl:       
> BSCF_AVAILABLEDATASIZEUNKNOWN = 0x10
> /usr/include/wine/windows/urlmon.h:    BSCF_AVAILABLEDATASIZEUNKNOWN = 0x10
> /usr/include/wx-2.6/wx/stc/stc.h:#define wxSTC_H_ATTRIBUTEUNKNOWN 4
> 
> this could be a reason if the error code doesn't exist on every machine

OK, it seems that EUNKNOWN isn't standard error code. Then maybe it's more
proper to fix in below way?

Index: libavcodec/avcodec.h
===================================================================
- --- libavcodec/avcodec.h        (revision 8240)
+++ libavcodec/avcodec.h        (working copy)
@@ -3045,7 +3045,12 @@
 #define AVERROR(e) (e)
 #define AVUNERROR(e) (e)
 #endif
- -#define AVERROR_UNKNOWN     AVERROR(EINVAL)  /**< unknown error */
+
+#if !defined( EUNKNOWN )
+#define EUNKNOWN (EINVAL)
+#endif
+
+#define AVERROR_UNKNOWN     AVERROR(EUNKNOWN)/**< unknown error */
 #define AVERROR_IO          AVERROR(EIO)     /**< i/o error */
 #define AVERROR_NUMEXPECTED AVERROR(EDOM)    /**< number syntax expected in
 filename */
 #define AVERROR_INVALIDDATA AVERROR(EINVAL)  /**< invalid data found */
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRevZhEztbf7dKiuoAQLqOAf/bZsIm3WAE1HXDupcQg7CrnJdSGB6Y3rC
XdZV5ruC6jqaSi72zw0CMu2o5jp2bxbgkcL7PEeIp0o9Yy+eXQXtXNhvCEhDozJw
NPYDjqFD4Ev5SofyXwEVGchIVeXxJp7gLjZvDiKNChDWuRSExcP+wYpPRJLUWQE8
7OX7OshYnIka0AKq2illWQwU8uXQE9ibKGbDWmn11Z1bdoeSul6rfg1EgrTGOz7o
MNkK/A2syOalZ32Ldc+k2NX4dxbLRHQBtQtML1YdWHgb5ErrKpVnoX7SGsBsWdro
7P9lN2iUbC51PINGPI5w7Ro1XH/0dMXnZZdBrkLc82ggN5szyzyT6w==
=kp+c
-----END PGP SIGNATURE-----




More information about the ffmpeg-devel mailing list