[Ffmpeg-devel] [PATCH] fix EINVAL TO EUNKNOWN

Michael Niedermayer michaelni
Mon Mar 5 12:00:01 CET 2007


Hi

On Mon, Mar 05, 2007 at 04:49:08PM +0800, Limin Wang wrote:
> Hi,
> 
> * Benoit Fouet <benoit.fouet at purplelabs.com> [2007-03-05 09:10:11 +0100]:
> 
> > Hi,
> > 
> > Limin Wang wrote:
> > > Hi,
> > >
> > > Any reason to convert unknown error to invalid error code? Or
> > > it's typo only.
> > >
> > FWIW this error code (EUNKNOWN) doesn't exist on my machine...
> > $ grep -R EUNKNOWN /usr/include/
> > /usr/include/nspr/plresolv.h:#define PL_RESOLVE_EUNKNOWN     
> > 7           /* berserk error */
> > /usr/include/wx/stc/stc.h:#define wxSTC_H_ATTRIBUTEUNKNOWN 4
> > /usr/include/wine/windows/urlmon.idl:       
> > BSCF_AVAILABLEDATASIZEUNKNOWN = 0x10
> > /usr/include/wine/windows/urlmon.h:    BSCF_AVAILABLEDATASIZEUNKNOWN = 0x10
> > /usr/include/wx-2.6/wx/stc/stc.h:#define wxSTC_H_ATTRIBUTEUNKNOWN 4
> > 
> > this could be a reason if the error code doesn't exist on every machine
> 
> OK, it seems that EUNKNOWN isn't standard error code. Then maybe it's more
> proper to fix in below way?

rejected, error codes MUST be consistent they cant change depending on
headers with specfic E* available during compile

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070305/0e6fb749/attachment.pgp>



More information about the ffmpeg-devel mailing list