[Ffmpeg-devel] Naming conventions

Måns Rullgård mans
Tue Mar 6 14:58:24 CET 2007


Michael Niedermayer said:
> Hi
>
> On Tue, Mar 06, 2007 at 02:18:17PM +0100, Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>> > Hi
>> >
>> > On Tue, Mar 06, 2007 at 01:37:00PM +0100, Baptiste Coudurier wrote:
>> > [...]
>> >>> and what about
>> >>>
>> >>> avpicture_get_size would that be av_picture_get_size or av_picture_size_get ?
>> >> av_picture_get_size, av_picture_fill, av_picture_pad ...
>> >
>> > why get_size? and not size_get? you mix type_action with action_type in a
>> > single name
>>
>> I don't mix them, type: av_picture, action: get_size
>
> why not type: av_picture_size action: get?
>
> the question maters for a naming convention ...
>
> also what would av_new_stream() be called then?
> av_format_context_new_stream() ? this is ugly
>
> and av_index_search_timestamp() would end with
> av_stream_index_timestamp_search() or av_stream_index_search_timestamp() or
> av_stream_search_index_timestamp()
>
> all depending on where the type ends not to mention the silly long
> name
> and the action is logically here on the index not on AVStream but
> AVStream is the type you must pass to the function!

Stop being facetious.  Please.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list