[Ffmpeg-devel] [PATCH] remove unused variables

Michael Niedermayer michaelni
Wed Mar 7 10:23:42 CET 2007


Hi

On Wed, Mar 07, 2007 at 05:04:18PM +0800, Limin Wang wrote:
> Hi,
> 
> * Michael Niedermayer <michaelni at gmx.at> [2007-03-07 09:43:05 +0100]:
> 
> > Hi
> > 
> > On Wed, Mar 07, 2007 at 02:37:21PM +0800, Limin Wang wrote:
> > > Hi,
> > > 
> > > Please review the patch. 
> > > 
> > > Thanks,
> > > Limin
> > 
> > [...]
> > >   the_end:
> > > -    av_free(buf);
> > > -    av_free(buf1);
> > > +    return;
> > >  }
> > 
> > the return statement is uneccesary except that the patch looks ok
> 
> Compile will fail for the_end label in the end if no return statement. 
> A separate patch will remove the_end label, then return can be removed.

ok, in that case iam fine with the patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070307/2c993282/attachment.pgp>



More information about the ffmpeg-devel mailing list