[Ffmpeg-devel] [PATCH] remove unused variables

Michel Bardiaux mbardiaux
Wed Mar 7 10:39:31 CET 2007


Michael Niedermayer wrote:
> Hi
> 
> On Wed, Mar 07, 2007 at 05:04:18PM +0800, Limin Wang wrote:
>> Hi,
>>
>> * Michael Niedermayer <michaelni at gmx.at> [2007-03-07 09:43:05 +0100]:
>>
>>> Hi
>>>
>>> On Wed, Mar 07, 2007 at 02:37:21PM +0800, Limin Wang wrote:
>>>> Hi,
>>>>
>>>> Please review the patch. 
>>>>
>>>> Thanks,
>>>> Limin
>>> [...]
>>>>   the_end:
>>>> -    av_free(buf);
>>>> -    av_free(buf1);
>>>> +    return;
>>>>  }
>>> the return statement is uneccesary except that the patch looks ok
>> Compile will fail for the_end label in the end if no return statement. 

Actually, you dont need a return statement, just *any* statement, 
including an empty one:

the_end:;
}


>> A separate patch will remove the_end label, then return can be removed.
> 
> ok, in that case iam fine with the patch
> 


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/




More information about the ffmpeg-devel mailing list