[Ffmpeg-devel] [PATCH] common AC-3 header parsing

Michael Niedermayer michaelni
Sun Mar 11 14:04:34 CET 2007


Hi

On Sat, Mar 10, 2007 at 10:43:53PM -0500, Justin Ruggles wrote:
> Justin Ruggles wrote:
> > Hi,
> > 
> > Here is one more step toward being able to submit a smaller AC-3 decoder
> > patch.  This one moves the header parsing to ac3.c so it can be used by
> > both the parser and the decoder.  I'm not completely sure if the Doxygen
> > stuff is correct, but I gave it my best shot.
> 
> Dangit.  I should've tested better.  New patch attached.

> Index: libavcodec/ac3.c
> ===================================================================
> --- libavcodec/ac3.c	(revision 8318)
> +++ libavcodec/ac3.c	(working copy)
> @@ -27,6 +27,7 @@
>  #include "avcodec.h"
>  #include "ac3.h"
>  #include "ac3tab.h"
> +#include "bitstream.h"
>  
>  static inline int calc_lowcomp1(int a, int b0, int b1, int c)
>  {
> @@ -208,3 +209,53 @@
>          ff_ac3_frame_sizes[i][2] = (  3*br      );
>      }
>  }
> +
> +int ac3_parse_header(const uint8_t buf[7], AC3HeaderInfo *hdr)

this should have a ff_ prefix

besides that patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070311/78a2011e/attachment.pgp>



More information about the ffmpeg-devel mailing list