[Ffmpeg-devel] [PATCH] common AC-3 header parsing

Justin Ruggles justinruggles
Sun Mar 11 17:45:32 CET 2007


Michael Niedermayer wrote:
> Hi
> 
> On Sat, Mar 10, 2007 at 10:43:53PM -0500, Justin Ruggles wrote:
> 
>>Justin Ruggles wrote:
>>
>>>Hi,
>>>
>>>Here is one more step toward being able to submit a smaller AC-3 decoder
>>>patch.  This one moves the header parsing to ac3.c so it can be used by
>>>both the parser and the decoder.  I'm not completely sure if the Doxygen
>>>stuff is correct, but I gave it my best shot.
>>
>>Dangit.  I should've tested better.  New patch attached.
> 
> 
>>Index: libavcodec/ac3.c
>>===================================================================
>>--- libavcodec/ac3.c	(revision 8318)
>>+++ libavcodec/ac3.c	(working copy)
>>@@ -27,6 +27,7 @@
>> #include "avcodec.h"
>> #include "ac3.h"
>> #include "ac3tab.h"
>>+#include "bitstream.h"
>> 
>> static inline int calc_lowcomp1(int a, int b0, int b1, int c)
>> {
>>@@ -208,3 +209,53 @@
>>         ff_ac3_frame_sizes[i][2] = (  3*br      );
>>     }
>> }
>>+
>>+int ac3_parse_header(const uint8_t buf[7], AC3HeaderInfo *hdr)
> 
> 
> this should have a ff_ prefix
> 
> besides that patch looks ok

Applied, with the suggested change.





More information about the ffmpeg-devel mailing list