[Ffmpeg-devel] Re: [RFC] Improvement for the odd timestampgeneration when parser is in use.

Michael Niedermayer michaelni
Fri Mar 23 02:07:43 CET 2007


On Wed, Mar 21, 2007 at 11:48:01PM +0100, elupus wrote:
> "elupus" <elupus at ecce.se> wrote in message 
> news:etpqk8$l4m$1 at sea.gmane.org...
> >Hi again,
> >
> >Here's next iteration of patch. It changes nothing about how parser works,
> >just makes it have a member variable wich gives the bytes after the start 
> >of
> >packet that gave the timestamps.
> >
> >It uses packet duration and size to estimate bitrate. This isn't entirely
> >right as it aught to be using the duration and size of last packet to do
> >this correction, but that isn't easily available. It is correct for cbr
> >streams atleast thou.
> >
> >Hope this fits the bill.
> >
> >/Joakim
> Typically a small type crept into the previous patch. Good that nobody 
> looked at it. Offset got calculated from wrong framestart. Here's a 
> corrected patch.

minor version of libavcodec should be increased
and the needs_parsing 3 should have a #define FOOBAR 3

besides that looks ok (assuming regressions tests pass)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070323/1d5b5e91/attachment.pgp>

More information about the ffmpeg-devel mailing list