[Ffmpeg-devel] [PATCH] fix 8x8 dct can't be set

Michael Niedermayer michaelni
Sat Mar 24 03:22:15 CET 2007


Hi

On Fri, Mar 23, 2007 at 07:21:24PM +0800, Limin Wang wrote:
> Hi,
> 
> It seems that it's opt parse bug, it can't process the flags which start by
> digit. After change 8x8dct to dct8x8, I can set it without problem. I guess
> nobody will use it since it can't work as expected, so the quick fix is change
> the option name. If you can fix the parse bug, that's cool also.
[...]
> -{"8x8dct", "high profile 8x8 transform (H.264)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_8X8DCT, INT_MIN, INT_MAX, V|E, "flags2"},
> +{"dct8x8", "high profile 8x8 transform (H.264)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_8X8DCT, INT_MIN, INT_MAX, V|E, "flags2"},

iam fine with the change unless the x264 maintainer objects

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070324/fc1c52a3/attachment.pgp>



More information about the ffmpeg-devel mailing list