[Ffmpeg-devel] [PATCH] fix 8x8 dct can't be set

Måns Rullgård mans
Sat Mar 24 13:00:52 CET 2007


Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Fri, Mar 23, 2007 at 07:21:24PM +0800, Limin Wang wrote:
>> Hi,
>> 
>> It seems that it's opt parse bug, it can't process the flags which
>> start by digit. After change 8x8dct to dct8x8, I can set it without
>> problem. I guess nobody will use it since it can't work as
>> expected, so the quick fix is change the option name. If you can
>> fix the parse bug, that's cool also.
> [...]
>> -{"8x8dct", "high profile 8x8 transform (H.264)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_8X8DCT, INT_MIN, INT_MAX, V|E, "flags2"},
>> +{"dct8x8", "high profile 8x8 transform (H.264)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_8X8DCT, INT_MIN, INT_MAX, V|E, "flags2"},
>
> iam fine with the change unless the x264 maintainer objects

No objections from me.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list