[Ffmpeg-devel] Re: [PATCH] Set bit_rate for asf format

Michael Niedermayer michaelni
Wed Mar 28 16:54:02 CEST 2007


Hi

On Wed, Mar 28, 2007 at 10:49:04PM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2007/3/28, Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br>:
> >Baptiste Coudurier wrote:
> >> Hi
> >>
> >> Zuxy Meng wrote:
> >>
> >>> Hi
> >>>
> >>> 2007/3/23, Michael Niedermayer <michaelni at gmx.at>:
> >>>
> >>>> Hi
> >>>>
> >>>> On Tue, Mar 20, 2007 at 12:40:19PM +0800, Zuxy Meng wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> As $subj. I tested with several asf files and the bitrate is the same
> >>>>> as reported by WMP.
> >>>>>
> >>>> patch ok, asf is a ugly beast ...
> >>>>
> >>>>
> >>> Anyone willing to apply it?
> >>>
> >>
> >> Yes, applied.
> >>
> >>
> >
> >It breaks regression tests with a bunch of "overflow in spectral RLE,
> >ignoring".
> 
> Are u sure it's caused by this patch and not by the recent wma
> improvement? bit_rate isn't used in decoding IIRC.

well whoever caused it should be flamed ...

and the change fixed or reversed of course ...

PS: patch submitters AND the person applying a patch are supposed to run the
regression tests

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070328/1f207b2a/attachment.pgp>



More information about the ffmpeg-devel mailing list