[Ffmpeg-devel] Re: [PATCH] Set bit_rate for asf format

Zuxy Meng zuxy.meng
Wed Mar 28 16:56:45 CEST 2007


Hi,

2007/3/28, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Wed, Mar 28, 2007 at 10:49:04PM +0800, Zuxy Meng wrote:
> > Hi,
> >
> > 2007/3/28, Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br>:
> > >Baptiste Coudurier wrote:
> > >> Hi
> > >>
> > >> Zuxy Meng wrote:
> > >>
> > >>> Hi
> > >>>
> > >>> 2007/3/23, Michael Niedermayer <michaelni at gmx.at>:
> > >>>
> > >>>> Hi
> > >>>>
> > >>>> On Tue, Mar 20, 2007 at 12:40:19PM +0800, Zuxy Meng wrote:
> > >>>>
> > >>>>> Hi,
> > >>>>>
> > >>>>> As $subj. I tested with several asf files and the bitrate is the same
> > >>>>> as reported by WMP.
> > >>>>>
> > >>>> patch ok, asf is a ugly beast ...
> > >>>>
> > >>>>
> > >>> Anyone willing to apply it?
> > >>>
> > >>
> > >> Yes, applied.
> > >>
> > >>
> > >
> > >It breaks regression tests with a bunch of "overflow in spectral RLE,
> > >ignoring".
> >
> > Are u sure it's caused by this patch and not by the recent wma
> > improvement? bit_rate isn't used in decoding IIRC.
>
> well whoever caused it should be flamed ...
>
> and the change fixed or reversed of course ...
>
> PS: patch submitters AND the person applying a patch are supposed to run the
> regression tests

I'll take caution next time. Sorry:-)
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list