[Ffmpeg-devel] Re: [PATCH] Second Try: Set bit_rate for asf format

Michael Niedermayer michaelni
Thu Mar 29 14:03:35 CEST 2007


Hi

On Thu, Mar 29, 2007 at 10:51:59AM +0800, Zuxy Meng wrote:
> Hi
> 
> 2007/3/29, Diego Biurrun <diego at biurrun.de>:
> >On Wed, Mar 28, 2007 at 04:46:09PM +0200, Baptiste Coudurier wrote:
> >> Ramiro Ribeiro Polla wrote:
> >> > Baptiste Coudurier wrote:
> >> >>
> >> >> Zuxy Meng wrote:
> >> >>
> >> >>> Anyone willing to apply it?
> >> >>
> >> >> Yes, applied.
> >> >
> >> > It breaks regression tests with a bunch of "overflow in spectral RLE,
> >> > ignoring".
> >>
> >> Humm, right, libavtest pass, but not fulltest:
> >>
> >> I revert the patch until this is stated, and will be more careful in the
> >> future.
> >
> >Actually, I think this is Zuxy's fault, not yours, patches are expected
> >not to break regression tests IMO.
> 
> Sure. And I've confirmed that the attached patch doesn't break fulltest.

setting bitrate just for video seems like a dirty hack, why did it break
audio? some check in wma.c maybe? why are you sure the video case wont 
break anything? wmv has (silly) bitrate based checks too IIRC

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070329/30ba9edd/attachment.pgp>



More information about the ffmpeg-devel mailing list