[Ffmpeg-devel] Re: [PATCH] Second Try: Set bit_rate for asf format

Zuxy Meng zuxy.meng
Fri Mar 30 03:37:57 CEST 2007


Hi,

2007/3/29, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Thu, Mar 29, 2007 at 10:51:59AM +0800, Zuxy Meng wrote:
> > Hi
> >
> >
> > Sure. And I've confirmed that the attached patch doesn't break fulltest.
>
> setting bitrate just for video seems like a dirty hack, why did it break
> audio? some check in wma.c maybe? why are you sure the video case wont
> break anything? wmv has (silly) bitrate based checks too IIRC
>

For wmv, bit_rate as set by lavf is used for encoding only; while for
wma it's used in ff_wma_init() which is shared between encoder and
decoder.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list