[Ffmpeg-devel] Re: [PATCH] Second Try: Set bit_rate for asf format

Zuxy Meng zuxy.meng
Fri Mar 30 04:44:17 CEST 2007


Hi,

2007/3/30, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Fri, Mar 30, 2007 at 09:37:57AM +0800, Zuxy Meng wrote:
> > Hi,
> >
> > 2007/3/29, Michael Niedermayer <michaelni at gmx.at>:
> > >Hi
> > >
> > >On Thu, Mar 29, 2007 at 10:51:59AM +0800, Zuxy Meng wrote:
> > >> Hi
> > >>
> > >>
> > >> Sure. And I've confirmed that the attached patch doesn't break fulltest.
> > >
> > >setting bitrate just for video seems like a dirty hack, why did it break
> > >audio? some check in wma.c maybe? why are you sure the video case wont
> > >break anything? wmv has (silly) bitrate based checks too IIRC
> > >
> >
> > For wmv, bit_rate as set by lavf is used for encoding only; while for
> > wma it's used in ff_wma_init() which is shared between encoder and
> > decoder.
>
> still i have a bad feeling with setting it just for video knowing it
> breakes audio if it would be set there too ...

Me too. I'll dig into wma.c this weekend.

> somehow this isnt a clean solution at all


-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list