[Ffmpeg-devel] Re: [PATCH] Second Try: Set bit_rate for asf format

Michael Niedermayer michaelni
Fri Mar 30 04:23:22 CEST 2007


On Fri, Mar 30, 2007 at 09:37:57AM +0800, Zuxy Meng wrote:
> Hi,
> 2007/3/29, Michael Niedermayer <michaelni at gmx.at>:
> >Hi
> >
> >On Thu, Mar 29, 2007 at 10:51:59AM +0800, Zuxy Meng wrote:
> >> Hi
> >>
> >>
> >> Sure. And I've confirmed that the attached patch doesn't break fulltest.
> >
> >setting bitrate just for video seems like a dirty hack, why did it break
> >audio? some check in wma.c maybe? why are you sure the video case wont
> >break anything? wmv has (silly) bitrate based checks too IIRC
> >
> For wmv, bit_rate as set by lavf is used for encoding only; while for
> wma it's used in ff_wma_init() which is shared between encoder and
> decoder.

still i have a bad feeling with setting it just for video knowing it
breakes audio if it would be set there too ...

somehow this isnt a clean solution at all

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070330/79bb0a24/attachment.pgp>

More information about the ffmpeg-devel mailing list