[FFmpeg-devel] [PATCH] Add rtsp options support ( added option)

Thijs Vermeir thijs.vermeir
Mon May 21 17:13:35 CEST 2007


Hi
> On Mon, 2007-05-21 at 15:13 +0200, Michael Niedermayer wrote:
> Hi
>
>  [...]
> >
> > Ok, I splitted the patches up in two incremental patches.
> > (1/2) -> Add support for options
> > (2/2) -> Add transport method options
>
> [...]
> > +    /* search for options */
> > +    option_list = strchr(path, '?');
> > +    if (option_list)
> > +    {
> > +        /* remove the options from the path */
>
> the {} placement is inconsistent with the rest of the file
>
>
> > +        path[option_list++ - path] = 0;
>
> obfuscated ...
>
> [...]
Thanks for your review,
In the patches applied this issues should be solved.

Gr,
Thijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp_options_1_of_2.patch
Type: text/x-patch
Size: 1336 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/bd0e5ace/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp_options_2_of_2.patch
Type: text/x-patch
Size: 1437 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/bd0e5ace/attachment-0001.bin>



More information about the ffmpeg-devel mailing list