[FFmpeg-devel] [PATCH] Add rtsp options support ( added option)

[Michael Niedermayer]

Hi

On Mon, May 21, 2007 at 05:13:35PM +0200, Thijs Vermeir wrote:
> Hi
> >On Mon, 2007-05-21 at 15:13 +0200, Michael Niedermayer wrote:
> >Hi
> >
> > [...]
> >>
> >> Ok, I splitted the patches up in two incremental patches.
> >> (1/2) -> Add support for options
> >> (2/2) -> Add transport method options
> >
> >[...]
> >> +    /* search for options */
> >> +    option_list = strchr(path, '?');
> >> +    if (option_list)
> >> +    {
> >> +        /* remove the options from the path */
> >
> >the {} placement is inconsistent with the rest of the file
> >
> >
> >> +        path[option_list++ - path] = 0;
> >
> >obfuscated ...
> >
> >[...]
> Thanks for your review,
> In the patches applied this issues should be solved.

[...]

> +        int length_of_path = option_list++ - path;
> +        path[length_of_path] = 0;

no this is even more obfuscated
its just a plain and simple
*option_list++ = 0;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/ed8e911e/attachment.pgp>