[FFmpeg-devel] [PATCH] move intrax8 tables from a header to a C file

Aurelien Jacobs aurel
Sat Nov 10 14:38:22 CET 2007

On Sat, 10 Nov 2007 14:05:05 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> AFAIU it is preferred to have tables in C files rather than in header
> files.

Prefered by whom ? Not by me.
At least not for tables which are not shared between several compilation

> Here is a patch to move the intrax8 tables to a C file, similar to what
> we did for the msmpeg4 tables.

The msmpeg4 case was different. Tables had to be used from different
compilation units.

> As a first step I could separate out moving the #defines over to
> intrax8.c.

IMO, this does no good, and uselessly makes some tables non-static.


More information about the ffmpeg-devel mailing list