[FFmpeg-devel] [PATCH] move intrax8 tables from a header to a C file
Sat Nov 10 17:59:01 CET 2007
On Sat, Nov 10, 2007 at 02:38:22PM +0100, Aurelien Jacobs wrote:
> On Sat, 10 Nov 2007 14:05:05 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> > AFAIU it is preferred to have tables in C files rather than in header
> > files.
> Prefered by whom ? Not by me.
> At least not for tables which are not shared between several compilation
> > Here is a patch to move the intrax8 tables to a C file, similar to what
> > we did for the msmpeg4 tables.
> The msmpeg4 case was different. Tables had to be used from different
> compilation units.
> IMO, this does no good, and uselessly makes some tables non-static.
OK, patch retracted.
> > As a first step I could separate out moving the #defines over to
> > intrax8.c.
IMO this still makes sense, having the #defines in intrax8huf.h is
confusing. Patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1255 bytes
Desc: not available
More information about the ffmpeg-devel