[FFmpeg-devel] [PATCH] dot_product() static non-inline in a header

Michael Niedermayer michaelni
Sun Dec 14 01:47:50 CET 2008

On Sun, Dec 14, 2008 at 01:45:16AM +0100, Aurelien Jacobs wrote:
> Hi,
> dot_product() is declared as static non-inline in celp_math.h, which
> generates some warning: 'dot_product' defined but not used.
> I'm not sure about the original intention, so here are two different
> patches (pick one of them):
>  - simply mark this function inline
>  - move this function in acelp_pitch_delay.c which is the only
>    file using it.

is there a speed gain from having it in te header inline?
if not iam in favor of ff_dot_product() in the .c file

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/66f32c61/attachment.pgp>

More information about the ffmpeg-devel mailing list