[FFmpeg-devel] [PATCH] dot_product() static non-inline in a header
Sun Dec 14 01:58:30 CET 2008
On Sun, 14 Dec 2008 01:47:50 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Dec 14, 2008 at 01:45:16AM +0100, Aurelien Jacobs wrote:
> > Hi,
> > dot_product() is declared as static non-inline in celp_math.h, which
> > generates some warning: 'dot_product' defined but not used.
> > I'm not sure about the original intention, so here are two different
> > patches (pick one of them):
> > - simply mark this function inline
> > - move this function in acelp_pitch_delay.c which is the only
> > file using it.
> is there a speed gain from having it in te header inline?
I have no idea, and I'm not really interested in testing this.
I hope someone more involved in celp will do it.
> if not iam in favor of ff_dot_product() in the .c file
That's another possiblity... Patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2112 bytes
Desc: not available
More information about the ffmpeg-devel