[FFmpeg-devel] [PATCH] Remove illegal "inline" specifiers

Uoti Urpala uoti.urpala
Sat Feb 2 03:41:58 CET 2008

mpegvideo.h has two function declarations with the 'inline' specifier
but no definition for those functions. The C standard requires a
definition to appear in the same translation unit for any function
declared with 'inline'. Most of the files including mpegvideo.h do not
define those functions. The attached patch fixes this by removing the
'inline' specifiers from the header.

Both of those functions also have the 'inline' specifier in their
definition. That seems stupid for at least ff_epzs_motion_search (it's
so big that inlining even within the translation unit where it's defined
is unlikely to make sense). That should probably be removed even if it's
not illegal. Current gcc chooses not to inline the function anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inline.diff
Type: text/x-patch
Size: 1013 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080202/5b535f89/attachment.bin>

More information about the ffmpeg-devel mailing list