[FFmpeg-devel] [PATCH] Remove illegal "inline" specifiers

Michael Niedermayer michaelni
Sat Feb 2 20:44:17 CET 2008

On Sat, Feb 02, 2008 at 04:41:58AM +0200, Uoti Urpala wrote:
> mpegvideo.h has two function declarations with the 'inline' specifier
> but no definition for those functions. The C standard requires a
> definition to appear in the same translation unit for any function
> declared with 'inline'. Most of the files including mpegvideo.h do not
> define those functions. The attached patch fixes this by removing the
> 'inline' specifiers from the header.
> Both of those functions also have the 'inline' specifier in their
> definition. That seems stupid for at least ff_epzs_motion_search (it's
> so big that inlining even within the translation unit where it's defined
> is unlikely to make sense). That should probably be removed even if it's
> not illegal. Current gcc chooses not to inline the function anyway.

patch ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080202/e3984d42/attachment.pgp>

More information about the ffmpeg-devel mailing list