[FFmpeg-devel] [PATCH] add alloc_put_byte function

Baptiste Coudurier baptiste.coudurier
Sun Feb 3 20:00:54 CET 2008


Reimar Doeffinger wrote:
> Hello,
> On Sun, Feb 03, 2008 at 05:32:35PM +0100, Baptiste Coudurier wrote:
>> Well, since you are giving some kind of proof that it's actually being
>> used outside, I therefore won't apply it without breaking API, so I
>> think I won't apply it soon, or I'll apply something not breaking API.
> If you want to change it, just change it. Now!
> There is no point in dragging this on forever, and then change it when everyone
> and their dogs are using it instead of now, API compatibility is a tool for a goal,
> not something to keep out of principle.

This change is only to keep functions names consistent within libavformat.


1) You applied it without considering my opinion just because you didn't
want to delay another patch. this is clearly NOT acceptable.

2) You did extend API without bumping minor.

3) Aurel emitted doubts about API breaking, and I won't ignore other's
opinions just because I want the change.

4) This once again proves that once patch hits svn it is really harder
to change it.

Now I consider, like Aurel, that this change will actually break API, so
Im reconsidering the change, because it is only justified for the sake
of naming consistency and will cause trouble for people already using it.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312

More information about the ffmpeg-devel mailing list