[FFmpeg-devel] [PACTH] Fix another problem in av_set_string()

Michael Niedermayer michaelni
Tue May 13 10:18:47 CEST 2008

On Tue, May 13, 2008 at 09:38:58AM +0200, Stefano Sabatini wrote:
> Hi all,
> since evaluation occurs on the buffer buf:
> d = ff_eval2(buf, const_values, const_names, NULL, NULL, NULL, NULL, NULL, &error);
> then avlog should report it when telling there was a parsing error here:
> if (error)
>    av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", val, error);
>                                                                            ^^^
> while the val contains the remaining part of the argument string still
> to be evaluated.
> This pach does s/val/buf/ in the abovementioned line.

ive rejected this patch already

the bug is that val+=i is done too early.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080513/9d1179f1/attachment.pgp>

More information about the ffmpeg-devel mailing list