[FFmpeg-devel] [PACTH] Fix another problem in av_set_string()

[Stefano Sabatini]

On date Tuesday 2008-05-13 10:18:47 +0200, Michael Niedermayer encoded:
> On Tue, May 13, 2008 at 09:38:58AM +0200, Stefano Sabatini wrote:
> > Hi all,
> > 
> > since evaluation occurs on the buffer buf:
> > d = ff_eval2(buf, const_values, const_names, NULL, NULL, NULL, NULL, NULL, &error);
> > 
> > then avlog should report it when telling there was a parsing error here:
> > if (error)
> >    av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", val, error);
> >                                                                            ^^^
> > while the val contains the remaining part of the argument string still
> > to be evaluated.
> > 
> > This pach does s/val/buf/ in the abovementioned line.
> 
> ive rejected this patch already
> 
> the bug is that val+=i is done too early.

mmh.. got it, please check this one.

Regards.
-- 
FFmpeg = Fiendish & Funny MultiPurpose EnGine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-av-set-string-01.patch
Type: text/x-diff
Size: 1111 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080513/b79ca0c1/attachment.patch>