[FFmpeg-devel] [PATCH] Implement version check in configure

Stefano Sabatini stefano.sabatini-lala
Sun Sep 21 21:18:22 CEST 2008


On date Sunday 2008-09-21 18:44:23 +0100, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > On date Saturday 2008-09-20 13:10:46 +0200, Stefano Sabatini encoded:
> >> On date Saturday 2008-09-20 12:25:21 +0200, Diego Biurrun encoded:
> >> > On Fri, Sep 19, 2008 at 12:23:52AM +0200, Stefano Sabatini wrote:
> >> > > 
> >> > > --- configure	(revision 15366)
> >> > > +++ configure	(working copy)
> >> > > @@ -608,6 +627,17 @@
> >> > >  
> >> > > +require3(){
> >> > 
> >> > This is not a good name.  Not that require2 was one, but let us not make
> >> > things worse.
> >> 
> >> require_headers_func_version?
> >> require_with_version?
> >> 
> >> Suggestions are welcome.
> >
> > Choosen the first one, seems more consistent with the new name for
> > check_func_headers used by Diego for another check function.
> 
> The name is way too long.

I suggest to keep the name of require3, then if we choose to use a
better name for require2 and require3 we can apply some consistent
rule.

> Furthermore, the test could be made more generic.

Tell if you like the patch below.

Regards.
-- 
FFmpeg = Forgiving and Frightening Martial Problematic Enhanced Gorilla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-version-03.patch
Type: text/x-diff
Size: 1644 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080921/433dde0c/attachment.patch>



More information about the ffmpeg-devel mailing list