[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (4/4) demuxer

Michael Niedermayer michaelni
Wed Sep 24 13:52:59 CEST 2008


On Wed, Sep 24, 2008 at 10:33:53AM +0200, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> > On Sat, Jul 12, 2008 at 02:17:03PM +0700, Vladimir Voroshilov wrote:
[...]
> > 
> > 
> >> +                          // Perform reordering
> >> +                          for(n=0; n < 38; n++) {
> >> +                              int j;
> >> +                              int i = bs * sipr_swaps[n][0];
> >> +                              int o = bs * sipr_swaps[n][1];
> >> +                                // swap nibbles of block 'i' with 'o'
> >> +                                for(j = 0;j < bs; j++) {
> > 
> > Fix the indention, and check if the code cannot write out of the
> > array. Ill checkit as well but the rm demuxer is messy its better if
> > its checked by more than 1 person.
> 
> Indentation fixed. To me by inspection the code looks ok, and this code
> has been running in mplayer for as long as it had binary rm codec
> support. And I ran it through valgrind with no complaints on a test file.

Could you try the code with some damaged files? (created by tools/trasher or
some other tool)

ill review the new patch soon.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080924/6c865af9/attachment.pgp>



More information about the ffmpeg-devel mailing list