[FFmpeg-devel] GSoC Qual VQA v3 : patch updated

The Deep Explorer thedeepexplorer
Mon Apr 13 20:19:07 CEST 2009


>
> I think so, however, there is still some cosmetic change in it that you should
> remove (yes, I know this breaks indentation and you are expected to submit
> another patch to fix it):
>
> -            src_pos = AV_RL16(&src[src_index]);
> +                src_pos = AV_RL16(&src[src_index]);

took care of this
>
> ...
>
> -            src_pos = AV_RB16(&src[src_index]) & 0x0FFF;
> +                src_pos = AV_RB16(&src[src_index]) & 0x0FFF;
>
> ...
done ..

>
> -    chunk_size = AV_RB32(&s->buf[vptz_chunk + 4]);
> -    vptz_chunk += CHUNK_PREAMBLE_SIZE;
> -    decode_format80(&s->buf[vptz_chunk], chunk_size,
> +        chunk_size = AV_RB32(&s->buf[vprz_chunk + 4]);
> +        vprz_chunk += CHUNK_PREAMBLE_SIZE;
> +        decode_format80(&s->buf[vprz_chunk], chunk_size,
>

In the other if constructs, which existed, I just used the style
it is not like this...may be am not getting this....can you elaborate
what you are saying..

> The indentation of new line 337(?) in westwood.c is not correct.
>

Changed ...
> Carl Eugen
>

Thanks,
-tde



More information about the ffmpeg-devel mailing list