[FFmpeg-devel] [PATCH] [RFC] Second try at pixdesc.h:write_line()

Michael Niedermayer michaelni
Tue Apr 14 13:28:33 CEST 2009


On Tue, Apr 14, 2009 at 10:33:05AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2009-04-14 04:21:51 +0200, Michael Niedermayer encoded:
> > On Tue, Apr 14, 2009 at 12:29:37AM +0200, Stefano Sabatini wrote:
> > > Hi all,
> > > 
> > > the attached patchset is an attempt at solving the bitstream
> > > randomization problem occurring when using skip_put_bits() and
> > > flush_put_bits().
> > > 
> > > Since the write_line() function has to keep intact the skipped
> > > content, I implemented the functions put_bits_save() and
> > > skip_put_bits_safe().
> > 
> > may i repeat my request to NOT use the bitstream writer for this
> 
> What do you suggest as alternative? The bitstream writer looks to me
> the natural choice.

the bitstream writer is a tool to write bits sequentially you arent doing
that.
What do i suggest as alternative? I suggest nothing, just write the code
we dont need to abstract from a single case
or change the way the code works so it does work sequentially, but that
may or may not be acceptable in terms of speed and prettiness

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090414/f8e55358/attachment.pgp>



More information about the ffmpeg-devel mailing list