[FFmpeg-devel] [PATCH] [RFC] Second try at pixdesc.h:write_line()

[Stefano Sabatini]

On date Tuesday 2009-04-14 13:28:33 +0200, Michael Niedermayer encoded:
> On Tue, Apr 14, 2009 at 10:33:05AM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2009-04-14 04:21:51 +0200, Michael Niedermayer encoded:
> > > On Tue, Apr 14, 2009 at 12:29:37AM +0200, Stefano Sabatini wrote:
> > > > Hi all,
> > > > 
> > > > the attached patchset is an attempt at solving the bitstream
> > > > randomization problem occurring when using skip_put_bits() and
> > > > flush_put_bits().
> > > > 
> > > > Since the write_line() function has to keep intact the skipped
> > > > content, I implemented the functions put_bits_save() and
> > > > skip_put_bits_safe().
> > > 
> > > may i repeat my request to NOT use the bitstream writer for this
> > 
> > What do you suggest as alternative? The bitstream writer looks to me
> > the natural choice.
> 
> the bitstream writer is a tool to write bits sequentially you arent doing
> that.
> What do i suggest as alternative? I suggest nothing, just write the code
> we dont need to abstract from a single case
> or change the way the code works so it does work sequentially, but that
> may or may not be acceptable in terms of speed and prettiness

Sorry to ask again, but what's the problem with extending put_bits()
to support safe skipping?

Alternatively I could couple a bitstream reader to the bitstream
writer, read and set again the read bits when I need to skip them, but
this won't be efficient.

The other alternative looks to me to rewrite from scratch a
non-sequential bitstream writer, since it is indeed that that I need.

Regards.
-- 
FFmpeg = Fundamental Fostering Mystic Pacific Educated Gorilla