[FFmpeg-devel] [PATCH] Fix monoblack pixdesc shift
Sat Apr 25 14:16:22 CEST 2009
On date Saturday 2009-04-25 14:03:39 +0200, Michael Niedermayer encoded:
> On Sat, Apr 25, 2009 at 09:50:07AM +0200, Stefano Sabatini wrote:
> > On date Friday 2009-04-24 02:21:11 +0200, Michael Niedermayer encoded:
> > > On Fri, Apr 24, 2009 at 02:02:29AM +0200, Stefano Sabatini wrote:
> > > > On date Friday 2009-04-24 01:40:46 +0200, Michael Niedermayer encoded:
> > > > > On Thu, Apr 23, 2009 at 11:58:22PM +0200, Stefano Sabatini wrote:
> > > > > > Hi, as in subject. Regards.
> > > > >
> > > > > I thought you tested your get_bits() replacement?
> > > >
> > > > No it makes no difference since shift is not used for bitstream
> > > > formats, but it looks weird anyway.
> > >
> > > if its not used the patch is useless
> > Still may be useful to the reader, having a non-used field set to 7
> > does not help understanding that it is unused.
> setting it to UNUSED and #define that to something would be clear but it
> would mess up the vertical alignment
What about this?
FFmpeg = Fierce and Friendly Mastodontic Programmable Exploitable Glue
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1710 bytes
Desc: not available
More information about the ffmpeg-devel