[FFmpeg-devel] [PATCH] Fix monoblack pixdesc shift
Sat Apr 25 14:19:02 CEST 2009
On Sat, Apr 25, 2009 at 02:16:22PM +0200, Stefano Sabatini wrote:
> On date Saturday 2009-04-25 14:03:39 +0200, Michael Niedermayer encoded:
> > On Sat, Apr 25, 2009 at 09:50:07AM +0200, Stefano Sabatini wrote:
> > > On date Friday 2009-04-24 02:21:11 +0200, Michael Niedermayer encoded:
> > > > On Fri, Apr 24, 2009 at 02:02:29AM +0200, Stefano Sabatini wrote:
> > > > > On date Friday 2009-04-24 01:40:46 +0200, Michael Niedermayer encoded:
> > > > > > On Thu, Apr 23, 2009 at 11:58:22PM +0200, Stefano Sabatini wrote:
> > > > > > > Hi, as in subject. Regards.
> > > > > >
> > > > > > I thought you tested your get_bits() replacement?
> > > > >
> > > > > No it makes no difference since shift is not used for bitstream
> > > > > formats, but it looks weird anyway.
> > > >
> > > > if its not used the patch is useless
> > >
> > > Still may be useful to the reader, having a non-used field set to 7
> > > does not help understanding that it is unused.
> > setting it to UNUSED and #define that to something would be clear but it
> > would mess up the vertical alignment
> What about this?
I think UNUSED should go in a more central internal header
and it should be defined in same nasty way so it is not always the same
like by using __LINE__ and the gcc version this would ensure it is really
unused (reg tests would break soon where it not unused ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel