[FFmpeg-devel] [PATCH] move RV10/20 encoder declarations to rv10.c
Mon Aug 3 14:46:47 CEST 2009
On Mon, Aug 03, 2009 at 01:07:42PM +0200, Michael Niedermayer wrote:
> On Mon, Aug 03, 2009 at 11:47:52AM +0200, Diego Biurrun wrote:
> > On Mon, Aug 03, 2009 at 03:47:19AM +0200, Michael Niedermayer wrote:
> > > On Sun, Aug 02, 2009 at 06:25:01PM +0200, Diego Biurrun wrote:
> > > > rv10.c looks like a better place for the RV10/20 encoder AVCodec
> > > > declarations.
> > >
> > > hmm, but all these h263 based AVCodec encoders are in mpegvideo_enc.c moving
> > > just rv10/20 out seems inconsistant ...
> > Well, you have to start somewhere. IIUC only RV10/20 has code outside
> > of mpegvideo_enc.c, which I intend to move to rv10enc.c afterwards...
> msmpeg4 / wmv surely have code outside too
Yes, for example wmv2enc.c where the WMV2 encoder gets declared.
I'm not sure what exactly your point is. Are you objecting to the move?
Note that all the AVCodec declarations in mpegvideo_enc.c are currently
lacking proper #ifdefs...
More information about the ffmpeg-devel