[FFmpeg-devel] [PATCH] move RV10/20 encoder declarations to rv10.c

Michael Niedermayer michaelni
Mon Aug 3 16:50:58 CEST 2009


On Mon, Aug 03, 2009 at 02:46:47PM +0200, Diego Biurrun wrote:
> On Mon, Aug 03, 2009 at 01:07:42PM +0200, Michael Niedermayer wrote:
> > On Mon, Aug 03, 2009 at 11:47:52AM +0200, Diego Biurrun wrote:
> > > On Mon, Aug 03, 2009 at 03:47:19AM +0200, Michael Niedermayer wrote:
> > > > On Sun, Aug 02, 2009 at 06:25:01PM +0200, Diego Biurrun wrote:
> > > > > rv10.c looks like a better place for the RV10/20 encoder AVCodec
> > > > > declarations.
> > > > 
> > > > hmm, but all these h263 based AVCodec encoders are in mpegvideo_enc.c moving
> > > > just rv10/20 out seems inconsistant ...
> > > 
> > > Well, you have to start somewhere.  IIUC only RV10/20 has code outside
> > > of mpegvideo_enc.c, which I intend to move to rv10enc.c afterwards...
> > 
> > msmpeg4 / wmv surely have code outside too
> 
> Yes, for example wmv2enc.c where the WMV2 encoder gets declared.
> 
> I'm not sure what exactly your point is.  

trust me, i dont know either, i was just commenting things that seemed
slightly unprecisse i did not mean anything beyond that


> Are you objecting to the move?

no

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090803/7cf746b1/attachment.pgp>



More information about the ffmpeg-devel mailing list