[FFmpeg-devel] [PATCH] Fix unaligned fill_rectangle in rv34.c
Thu Aug 20 10:09:56 CEST 2009
On Thu, Aug 20, 2009 at 09:57:32AM +0200, Reimar D?ffinger wrote:
> On Thu, Aug 20, 2009 at 10:33:19AM +0300, Kostya wrote:
> > Probably better solution would be to disable this code automatically for
> > such archs. I don't remember an outcome of my discussion with Mans
> > about that though.
> Don't see any need for it, AFAICT only the 64 bit writes are an issue
> and I am not convinced they are that much of an advantage.
I mean "that much of an advantage when they are unaligned". I think that
can even be quite costly on x86_64 when it crosses a cache line.
So my alternative suggestion would be to completely disable the 64 bit
code in fill_rectangle to RV, for all architectures.
Though I think that should be benchmarked (not by me!), it could be
faster or slower...
More information about the ffmpeg-devel